Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )
Change subject: arch/x86/smbios: Add SMBIOS type8 data
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h@586
PS7, Line 586: uint8_t
why are you not using the enums defined above? […]
I just follow other's way
https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h@591
PS7, Line 591: uint8_t
other struct use the kernel notation u8
Someone ask me not to use C99 type, I'm not so sure which one I need to use for typedef, it seems both them are fine in coreboot's coding style, could you instruct me how to use it? thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81e25d27c9c6717750edf1d547e5f4cfb8f1da14
Gerrit-Change-Number: 40545
Gerrit-PatchSet: 7
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:55:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment