Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40579 )
Change subject: vboot: Add permission check for kernel space ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40579/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40579/6//COMMIT_MSG@13 PS6, Line 13: Signed-off-by: dnojiri dnojiri@chromium.org Please use you full name and move the SoB line right below the Change-Id line.
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/40579/6/src/security/vboot/secdata_... PS6, Line 86: "TPM: invalid secdata_kernel permissions\n"); This should fit in one line.