Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34501 )
Change subject: Get HyperThreading setting from RW_VPD for FSP UPD ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34501/3/src/drivers/vpd/vpd_decode.... File src/drivers/vpd/vpd_decode.c:
https://review.coreboot.org/c/coreboot/+/34501/3/src/drivers/vpd/vpd_decode.... PS3, Line 6: This is a copy from upstream: : * https://chromium.googlesource.com/chromiumos/platform/vpd/+/master/lib/vpd_d... this is a direct copy from upstream. Please keep it untouched so we can sync with upstream in future.
You may instead put that in your board-specific logic, or a new one in vpd folder.
https://review.coreboot.org/c/coreboot/+/34501/3/src/drivers/vpd/vpd_decode.... PS3, Line 110: search Are you using CrOS VPD 2.0 format? https://chromium.googlesource.com/chromiumos/platform/vpd/+/master/
If not, then this should be in your own VPD module, not with vpd_decode (which is for CrOS VPD).