awokd@danwin1210.me has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36001 )
Change subject: vc/amd/agesa/f16kb: Remove redundant FIS code ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36001/2/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/Fch/Sata/Family/Yangtze/YangtzeSataService.c:
https://review.coreboot.org/c/coreboot/+/36001/2/src/vendorcode/amd/agesa/f1... PS2, Line 370: // FchSataFisBasedSwitching
If I'd read the comment without seeing this commit, I'd think that the line below is because that fl […]
The original vendorcode is the same either path, unlike the other capabilities. If I'm following the bit flips correctly (not a given), they're disabling it even if the device reports it is capable.