Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49936 )
Change subject: mb/intel/adlrvp: Configure GPIOs related to ADL-M
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49936/comment/62d55355_2fd9e5f8
PS1, Line 7: bootblock-$(CONFIG_BOARD_INTEL_ADLRVP_P) += early_gpio.c
will this work for you, i believe then it would look much clean
ifeq ($(CONFIG_SOC_INTEL_ALDERLAKE_PCH_M),y)
bootblock-y += early_gpio_m.c
ramstage-y += gpio_m.c
else
bootblock-y += early_gpio.c
ramstage-y += gpio.c
endif
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49936
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03a532f69f42db723b976a0f7b0acf6f4b98e354
Gerrit-Change-Number: 49936
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 15:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment