Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45000 )
Change subject: Revert "soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled"
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Hey folks, does anyone have an opinion on this? I'd prefer to
get it in, simply because it avoids complexity. I don't think,
but can't prove, that it's really harmless to have both the
emulation and the actual timer available.
https://review.coreboot.org/c/coreboot/+/45000/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45000/1//COMMIT_MSG@11
PS1, Line 11: BIOS spec says, emulation shall be always enabled.
thanks, reworded this
It's not unambiguous... Could also mean that this particular order is
required if it's going to be enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0d7fa6f9766c7c4e2fa9e846c179adc6a4e1681
Gerrit-Change-Number: 45000
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 20:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment