build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35303 )
Change subject: mb/google/drallion: Enable 360 sensor detection ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 291: FSP_M_CONFIG *fsp_m_cfg = &mupd->FspmConfig; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 292: if (fsp_m_cfg->PchIshEnable) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 292: if (fsp_m_cfg->PchIshEnable) suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 293: fsp_m_cfg->PchIshEnable = is_ish_device_enabled(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35303/7/src/mainboard/google/dralli... PS7, Line 293: fsp_m_cfg->PchIshEnable = is_ish_device_enabled(); please, no spaces at the start of a line