Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... PS4, Line 66: /* H4 : PCH_I2C_PEN_SDA */ : PAD_CFG_NF(GPP_H4, NONE, DEEP, NF1), : /* H5 : PCH_I2C_PEN_SCL */ : PAD_CFG_NF(GPP_H5, NONE, DEEP, NF1), :
This is fine, just a note that I'm pretty sure FSP is doing this same thing; these are set as PAD_NC […]
Yeah, I believe it is based on the SerialIoDevConfig.
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34581/4/src/mainboard/google/hatch/... PS4, Line 87: ACPI_GPIO_IRQ_LEVEL_LOW
ACPI_GPIO_IRQ_EDGE_BOTH? Don't we need an IRQ on both edges for stylus toolbar show/hide?
Based on the name of the member, it looks like we are just sharing information about the GpioIO() in the _CRS and gpio_keys kernel driver uses that to request the right IRQ. It would be good to check what exactly the expectation is.