[coreboot-gerrit] Change in coreboot[master]: superio/nuvoton/nct5104d: assign IO port range to control GPIO

[Piotr Kleinschmidt (Code Review)]

Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )

Change subject: superio/nuvoton/nct5104d: assign IO port range to control GPIO
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35849/2/src/superio/nuvoton/nct5104... 
File src/superio/nuvoton/nct5104d/superio.c:

https://review.coreboot.org/c/coreboot/+/35849/2/src/superio/nuvoton/nct5104... 
PS2, Line 111: static void disable_gpio_io_port(struct device *dev)
> this function seems to be rather board-specific to me. […]

I wasn't sure if io-mapped gpio won't collide in some cases if uart is set. However, as you said it won't, io-mapped can be always enabled and therefore that function is not needed anymore.