Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39074 )
Change subject: sb/intel/{bd82x6x,ibexpeak}: hide MEI if ME inoperable
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39074/1/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/me.c:
https://review.coreboot.org/c/coreboot/+/39074/1/src/southbridge/intel/bd82x...
PS1, Line 695: ME_ERROR_BIOS_PATH
BIOS shouldn't hide ME device by default on error path (me_cleaner is not the only possible reason o […]
Done
https://review.coreboot.org/c/coreboot/+/39074/1/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/39074/1/src/southbridge/intel/bd82x...
PS1, Line 684: ME_ERROR_BIOS_PATH
Same as in me.c.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a35bf5fc196e0a02b7591cdb8633d38f0c7f3e
Gerrit-Change-Number: 39074
Gerrit-PatchSet: 3
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 01:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Gerrit-MessageType: comment