Attention is currently required from: Simon Chou, Johnny Lin, Subrata Banik, Arthur Heymans, Ray Han Lim Ng, Srinidhi N Kaushik, Andrey Petrov.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71951 )
Change subject: drivers/intel/fsp2_0: include IioPcieConfigUpd.h
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:
https://review.coreboot.org/c/coreboot/+/71951/comment/5a862756_8fc6b659
PS2, Line 39: #if CONFIG(SOC_INTEL_SAPPHIRERAPID_SP)
: #include <IioPcieConfigUpd.h>
: #endif
This is really not the place for SOC dependent code. […]
With SPR-SP, the IIO PCIe config becomes comprehensive, so the definitions are separated out from the FSP header file. In other words, IioPcieConfigUpd.h is actually part of FSP header. Another option is for FspmUpd.h to include this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie81d9967fdf55d0b234b2987a708edc73cf6dcb3
Gerrit-Change-Number: 71951
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Ray Han Lim Ng
ray.han.lim.ng@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ray Han Lim Ng
ray.han.lim.ng@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 22:45:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment