Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36937 )
Change subject: lib/fmap: Disable pre-RAM cache for FSP 1.0
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Waiting for Siemens folks to confirm, some nits, but otherwise looks good. Thanks!
https://review.coreboot.org/c/coreboot/+/36937/3/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36937/3/src/lib/fmap.c@77
PS3, Line 77: affort
afford
https://review.coreboot.org/c/coreboot/+/36937/3/src/lib/fmap.c@78
PS3, Line 78: print_once(BIOS_ERR,
single line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ffb1b8b08a7ca3fe8d53dc827e2c8521da064c7
Gerrit-Change-Number: 36937
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: uwe taz
Gerrit-Comment-Date: Mon, 18 Nov 2019 22:49:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment