Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49201 )
Change subject: mb/google/parrot: Put trailing statement in the next line ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
According to our coding style [1], this time the linter is correct: […]
But is hiding an empty statement hiding something?
Anyway, IMO, the only good solution is to move the side-effect expression out of the condition. One would need to add some state variable in this case, though.
My usual argument against the semicolon on an empty line is my fear that at some point somebody will grep for useless semicolons and reviewers might miss to correct some of the false positives.
Or how about this:
while (side_effect()) { /* do nothing */ }