Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add a GPIO table for initializing custom configurations
......................................................................
Patch Set 3:
Patch Set 2:
(14 comments)
I went thru the GPIO listing and have a few questions, particular concerning the MGPIOs, SATA pins, and OC pins.
Some GPIOs listed don't seem to exist. It should be safe to set them as inputs as you have done, I just wanted to note them in case we're looking at different schematics/datasheets.
Your gpio findings are correct with our schematics.
We configure these gpios by following the proprietary UEFI BIOS configurations,
after comparing the ITP gpio dump they are the same after applying this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74906bf9395a333be6250ffbd181da536e016f30
Gerrit-Change-Number: 35367
Gerrit-PatchSet: 3
Gerrit-Owner: Jingle Hsu
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
johnnylin0924@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Fri, 27 Sep 2019 09:38:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment