[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 18:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@63 
PS7, Line 63: 				 uint8_t blue_mask_size)
> that only works if all arguments are fields withing the lb_framebuffer struct, which is not the case […]

Future commits aren't fully reviewed yet, so this should stay open.

https://review.coreboot.org/c/coreboot/+/39002/14/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/14/src/lib/edid_fill_fb.c@78 
PS14, Line 78: 		bits_per_pixel = bpp_mask;
> Done. […]

Yes, it's to be used to calculate the location of a pixel in memory,
hence has to include gaps.