Attention is currently required from: Nico Huber, maciej.gabryelski@3mdeb.com, Martin L Roth, Michał Kotyla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 )
Change subject: util/ectool/Makefile : improve cross-compilation support ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70102/comment/3f1ae7a4_3299f595 PS1, Line 7: util/ectool/Makefile : Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/70102/comment/2efc74e2_c438dee5 PS1, Line 11: buildsystem like Yocto Please add a dot/period at the end of sentences.
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/70102/comment/a864555e_bfe5750b PS1, Line 3: CC ?= gcc Do you have more information regarding this. I did this in the past, but found out, that passing it as a “make variable” (and not environment) it can be easily overridden, so stayed away from it. So,
make CC=clang
works already. Why should `CC=clang make` be supported too? Please elaborate in the commit message.