Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45997 )
Change subject: soc/intel/common/block/acpi: Factor out common gfx.asl
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Patch Set 1:
Hi Duncan,
Do you think we need to add IGD ASL device entry for other SOC as well?
It is probably good to be consistent and add it in the common code for other SOC. The entry itself in the DSDT doesn't do much but it allows the ports to be defined in devicetree and get generated in the SSDT.
Thanks Duncan, i will add gfx.asl for other SoC as well to ensure its align.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45997
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie34181a6783d348265cf4299dec5c41e7f4f736f
Gerrit-Change-Number: 45997
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Mon, 05 Oct 2020 16:24:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment