uwe.poeche@siemens.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36643 )
Change subject: src/mainboard/siemens: Use PTN3460 chip driver
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36643/1/src/mainboard/siemens/mc_ap...
File src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36643/1/src/mainboard/siemens/mc_ap...
PS1, Line 96: external
double external […]
Done
https://review.coreboot.org/c/coreboot/+/36643/1/src/mainboard/siemens/mc_ap...
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36643/1/src/mainboard/siemens/mc_ap...
PS1, Line 23:
I think you can remove this file.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I976a502e7176a356bab772758250db3cdff529b9
Gerrit-Change-Number: 36643
Gerrit-PatchSet: 2
Gerrit-Owner: uwe taz
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: uwe taz
Gerrit-Reviewer: uwe.poeche@siemens.com
Gerrit-Comment-Date: Wed, 06 Nov 2019 15:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment