Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30906 )
Change subject: [WIP]mb/fujitsu/d3041-a1: Add mainboard
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks fine, probably needs a rebase or something
https://review.coreboot.org/#/c/30906/1/src/mainboard/fujitsu/d3041-a1/Kconf...
File src/mainboard/fujitsu/d3041-a1/Kconfig:
https://review.coreboot.org/#/c/30906/1/src/mainboard/fujitsu/d3041-a1/Kconf...
PS1, Line 39: string
: default "fujitsu/d3041-a1"
:
: config MAINBOARD_PART_NUMBER
: string
: default "D4041-A1"
Why the difference?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eeddfde84fc93a6f285fd8c20a56ff63335a02f
Gerrit-Change-Number: 30906
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Apr 2019 12:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment