Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40282 )
Change subject: mb/google/puff: Add variant specific DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40282/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/40282/1/src/mainboard/google/hatch/...
PS1, Line 13: */
Please use SPDX license header.
Could you provide the header? I'm not sure which is the correct format.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36db172e4d2ccc854856641c510cff9fe04ea235
Gerrit-Change-Number: 40282
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Chen
tim-chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 08:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment