Attention is currently required from: Francois Toguo Fotso, Paul Menzel, Curtis Chen, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59951 )
Change subject: soc/intel/alderlake: Add crashlog trigger on all reset toggle soc/intel/common: Do not enable crashlog on all resets by default
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Do you mind splitting this into two commits, one for the Kconfig, and the other to enable it for ADL?
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/59951/comment/18b0d9b4_bc2e3cef
PS2, Line 332: def_bool n
: help
: Enable PMC reset crashlog record.
indent with tabs (this is the cause of the jenkins failure)
also since the Kconfig is used in common code, this Kconfig needs to live in
`src/soc/intel/common/block/crashlog/Kconfig` instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139
Gerrit-Change-Number: 59951
Gerrit-PatchSet: 2
Gerrit-Owner: Curtis Chen
curtis.chen@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 09 Dec 2021 18:01:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment