build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34790 )
Change subject: vboot: fix conditional using vboot_setup_tpm return value
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34790/1/src/security/vboot/vboot_lo...
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/34790/1/src/security/vboot/vboot_lo...
PS1, Line 338: if (TPM_SUCCESS == vboot_setup_tpm(&ctx))
Comparisons should place the constant on the right side of the test
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdea1d85167a50a1ada5afe9b107408e3a2e0d6f
Gerrit-Change-Number: 34790
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Aug 2019 06:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment