Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43719 )
Change subject: arch/x86/smbios: Bump to version 3.0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43719/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43719/1/src/arch/x86/smbios.c@750
PS1, Line 750: t->core_enabled2 = 0; /* Unknown */
it also states that zero is always valid value.
I dont see that - for me it clearly states:
For core counts of 256 or greater, the Core Countfield is set to FFh and the Core Count 2field is set to the number of cores.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba7a54e9de0b315f8072e6fd2880582355132a81
Gerrit-Change-Number: 43719
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 09:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment