Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc...
File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc...
PS10, Line 68: uint32_t
Done. Changed.
Done
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc...
PS10, Line 68: F17H_MPB_MAX_SIZE
the file is picasso-specific, so the prefix is not really needed, but i also don't see necessity to […]
Done. Removed prefix F17.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib08a65b93c045afc97952a809670c85831c0faf7
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 24
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 03:33:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment