Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36700 )
Change subject: sb/intel/i82801gx: Add common LPC decode code ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36700/3/src/mainboard/asus/p5gc-mx/... File src/mainboard/asus/p5gc-mx/romstage.c:
https://review.coreboot.org/c/coreboot/+/36700/3/src/mainboard/asus/p5gc-mx/... PS3, Line 147: i82801gx_lpc_decode();
hmmm, twice?
Done
https://review.coreboot.org/c/coreboot/+/36700/3/src/mainboard/kontron/986lc... File src/mainboard/kontron/986lcd-m/romstage.c:
https://review.coreboot.org/c/coreboot/+/36700/3/src/mainboard/kontron/986lc... PS3, Line 211: i82801gx_lpc_decode();
better the other way around?
Done
https://review.coreboot.org/c/coreboot/+/36700/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/36700/4/src/southbridge/intel/i8280... PS4, Line 47: if (!config) that's already checked three lines above