21 Nov
2022
21 Nov
'22
9:23 a.m.
Attention is currently required from: Mario Scheithauer, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ......................................................................
Patch Set 14:
(1 comment)
File src/drivers/net/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/2dc97046_0fed2a28 PS14, Line 18: page_reg Is this still the 'page_reg'? This name can lead to confusions with the real PAGE_REG. Do you mind to rename it just to reg or so?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69386
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904
Gerrit-Change-Number: 69386
Gerrit-PatchSet: 14
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 21 Nov 2022 07:23:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment