Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36908 )
Change subject: lib/fmap.c: Properly handle cache for !C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36908/2/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36908/2/src/lib/fmap.c@65
PS2, Line 65: #endif
Okay, I mean... […]
Ack, as this patch didn't make it into 4.11, it's more interesting for other
potential branches. And even there, it depends on how maintainers want
to handle things (e.g. if it will be a c-env-bootblock-free branch, it
won't matter either).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d70585b0c076707e73e20c2ed3f11e4c9ffdf37
Gerrit-Change-Number: 36908
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 17:27:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment