Attention is currently required from: Robert Zieba, Nico Huber, Raul Rangel, Arthur Heymans, Tim Wawrzynczak, Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63657 )
Change subject: arch/x86: Add support for catching null deferences through debug regs ......................................................................
Patch Set 5:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63657/comment/1a9ff66a_a32a0fbb PS5, Line 9: deferences Ditto.
https://review.coreboot.org/c/coreboot/+/63657/comment/f1279538_3b348758 PS5, Line 12: have been Present tense: are
https://review.coreboot.org/c/coreboot/+/63657/comment/78d75780_4894080f PS5, Line 18: expected How can this be tested exactly? Does it also work in QEMU?
Patchset:
PS5: Can you please make sure, it also builds with clang?
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/63657/comment/0771932f_73e378ae PS5, Line 327: Enables Imperative mood seems to be used in this file: Enable.
https://review.coreboot.org/c/coreboot/+/63657/comment/1aa3b797_4562727a PS5, Line 335: deferences Ditto.
https://review.coreboot.org/c/coreboot/+/63657/comment/f6a203f1_a1fe768a PS5, Line 335: Enables Ditto.
https://review.coreboot.org/c/coreboot/+/63657/comment/ebe77f20_26cf1837 PS5, Line 342: deferences Ditto.
File src/arch/x86/breakpoint.c:
https://review.coreboot.org/c/coreboot/+/63657/comment/22373d96_d2a47c13 PS5, Line 280: #if ENV_X86_64 Is it possible to check this in C code?