28 May
2020
28 May
'20
8:30 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41747 )
Change subject: lockdown: Add Kconfigs for SPI media protection mode ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41747/5/src/drivers/spi/boot_device... File src/drivers/spi/boot_device_rw_nommap.c:
https://review.coreboot.org/c/coreboot/+/41747/5/src/drivers/spi/boot_device... PS5, Line 105: else if (CONFIG(BOOTMEDIA_SPI_LOCK_PERMANENT)) : lock = SPI_WRITE_PROTECTION_PERMANENT; Is this something the firmware (as opposed to the OS, ensuring the system actually boots) should ever do?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba7c1229c82c86e1303d74c7bc8f89662b5bb58c
Gerrit-Change-Number: 41747
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Gröber (dxld)
Gerrit-Reviewer: Daniel Gröber dxld@darkboxed.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 28 May 2020 11:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment