Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34343 )
Change subject: configs/config.facebookfbg1710: Add config file
......................................................................
Patch Set 1:
I think that needs to be "config.facebook_fbg1710" or "config.facebook_fbg1710_some_description_here", as I don't see it in the Jenkins build log.
It's always good to give a short summary in the file, where it's different from default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2cb3bb873b2d5e7e9031e5b249d86605d8e0945
Gerrit-Change-Number: 34343
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jul 2019 09:22:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment