Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35228/18//COMMIT_MSG@12 PS18, Line 12: Verified sending HECI global reset message on CML RVP & Hatch board verified on ICL and SKL or KBL too?
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/16/src/soc/intel/common/block... PS16, Line 598: (rst_type == GLOBAL_RESET)
Done
I meant the braces around the conditions can go and not needed.
rst_type == HOST_RESET_ONLY || rst_type == CSE_RESET_ONLY
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... PS18, Line 114: u8 declaration and definition needs to be aligned.