Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config ......................................................................
Patch Set 21:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37427/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37427/17//COMMIT_MSG@13 PS17, Line 13: .G
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... PS12, Line 78: LAnd (LGreaterEqual (Arg0, GPP_B0), LLessEqual (Arg0, ESPI_CLK_LOOPBK))
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... PS12, Line 101: 05
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... PS12, Line 101: *
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... PS12, Line 140: And (GPIOTXSTATE_MASK, VAL0, Local0)
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/12/src/soc/intel/tigerlake/ac... PS12, Line 159:
Ack
Ack
https://review.coreboot.org/c/coreboot/+/37427/17/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/37427/17/src/soc/intel/tigerlake/in... PS17, Line 4: 2019
Sure, that's fine.
Ack
https://review.coreboot.org/c/coreboot/+/37427/17/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/37427/17/src/soc/intel/tigerlake/in... PS17, Line 4: 2019
Ack
Ack