build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31590 )
Change subject: google/kukui: Add panel config data for display ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 81: {INIT_CMD, 1, {MIPI_DCS_EXIT_SLEEP_MODE}}, space required after that close brace '}'
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 82: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 83: {INIT_CMD, 1, {MIPI_DCS_SET_DISPLAY_ON}}, space required after that close brace '}'
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 84: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 103: false, &edid, lcm_init_cmd, sizeof(lcm_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters