build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47388 )
Change subject: soc/intel/elkhartlake: Adding PSE TSN support & PSE UPDs configs ......................................................................
Patch Set 2:
(49 comments)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/K... File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/K... PS2, Line 236: string "TSN MAC adress binary path and filename" 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/K... PS2, Line 239: The path and filename of the TSN mac adress binary. 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 42: PSE_CONFIG_PSEowned =0x1, spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 79: if (CONFIG(PSE_IMAGE)) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 79: if (CONFIG(PSE_IMAGE)) suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 109: params->PchPseTgpio7PinMux= 0x8B82A40B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 110: params->PchPseTgpio8PinMux= 0x8B80A607; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 111: params->PchPseTgpio9PinMux= 0x8B80A808; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 112: params->PchPseTgpio10PinMux= 0x8B86AA07; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 113: params->PchPseTgpio11PinMux= 0x8B86AC0B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 114: params->PchPseTgpio12PinMux= 0x8B86AE13; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 115: params->PchPseTgpio13PinMux= 0x8B85B00C; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 116: params->PchPseTgpio14PinMux= 0x8B90B214; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 117: params->PchPseTgpio15PinMux= 0x8B90B403; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 118: params->PchPseTgpio16PinMux= 0x8B90B607; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 119: params->PchPseTgpio17PinMux= 0x8B90B80F; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 120: params->PchPseTgpio18PinMux= 0x8B90BA06; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 121: params->PchPseTgpio19PinMux= 0x8B8DBC01; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 124: params->PchPsePwmPinMux[8]= 0x7B706604; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 125: params->PchPsePwmPinMux[9]= 0x7B706805; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 126: params->PchPsePwmPinMux[10]= 0x7B706A06; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 127: params->PchPsePwmPinMux[11]= 0x7B706C11; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 128: params->PchPsePwmPinMux[12]= 0x7B706E12; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 129: params->PchPsePwmPinMux[13]= 0x7B707013; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 130: params->PchPsePwmPinMux[14]= 0x4B64720A; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 131: params->PchPsePwmPinMux[15]= 0x4B64740B; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 132: params->PchPseSpiMosiPinMux[1]= 0x4B852003; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 133: params->PchPseSpiMisoPinMux[1]= 0x4B853002; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 134: params->PchPseSpiClkPinMux[1]= 0x4B854001; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 135: params->PchPseSpiCs0PinMux[1]= 0x4B855000; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 136: params->PchPseI2sTxPinMux[0]= 0x1B702610; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 137: params->PchPseI2sRxPinMux[0]= 0x1B70160F; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 138: params->PchPseI2sSfrmPinMux[0]= 0x1B704614; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 139: params->PchPseI2sSclkPinMux[0]= 0x1B703615; spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 142: params->EnableAllThermalFunctions =0x1; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 143: params->PchPseEcliteEnabled =0x0; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 145: if (CONFIG(ENABLE_TSN)){ suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 145: if (CONFIG(ENABLE_TSN)){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 146: params->PchPseGbeEnable[0]=config->PSE_TSN[0]; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 147: params->PchPseGbeEnable[1]=config->PSE_TSN[1]; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 148: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 150: params->TsnMacAddrBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 154: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 155: params->TsnConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 160: params->PseTsnIpConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 165: params->PseTsnGbeSgmiiEnable[0]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 166: params->PseTsnGbeSgmiiEnable[1]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 167: params->PseTsnGbePhyInterfaceType[0]=0x1; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47388/2/src/soc/intel/elkhartlake/f... PS2, Line 168: params->PseTsnGbePhyInterfaceType[1]=0x1; spaces required around that '=' (ctx:VxV)