Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )
Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code
......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c
File src/soc/intel/skylake/me.c:
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c...
PS18, Line 245:
remove this extra line ?
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c...
PS18, Line 491: return status;
goto ret; just to make consistency if you wish ?
https://review.coreboot.org/c/coreboot/+/35225/18/src/soc/intel/skylake/me.c...
PS18, Line 495:
same here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdbfb6b30a007d469b5e018a313c14586addb130
Gerrit-Change-Number: 35225
Gerrit-PatchSet: 18
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Sep 2019 07:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment