Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48000 )
Change subject: mb/intel/adlrvp: Enable I2S Audio for ADLRVP ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/... PS1, Line 145: register "PchHdaAudioLinkSndwEnable[0]" = "1" : register "PchHdaAudioLinkSndwEnable[1]" = "1"
please remove this too for I2S
Done
https://review.coreboot.org/c/coreboot/+/48000/5/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48000/5/src/mainboard/intel/adlrvp/... PS5, Line 233: end # I2C0
submit a separate CL, i will review
Done
https://review.coreboot.org/c/coreboot/+/48000/5/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48000/5/src/mainboard/intel/adlrvp/... PS5, Line 90: device pci 1f.3 on end #Intel Audio
why we need this here ?
Ack