Anna Karaś has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42311 )
Change subject: tests: Complete lib/string-test test case ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@a10 PS1, Line 10: One can use __builtin_xxx for many of the most simple str*() : * functions, when non-coreboot one is required.
Actually this comment is dangerous a little bit. Most of calls to the __builtin_*() functions (e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@33 PS1, Line 33: struct str_with_l_val_t {
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@126 PS1, Line 126: assert_ptr_not_equal(str + 2, strrchr(str, 'r'));
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@135 PS1, Line 135: DST_SIZE
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@139 PS1, Line 139: n
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@159 PS1, Line 159: assert_true(dst[__builtin_strlen(dst)] == '\0');
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@168 PS1, Line 168: assert_int_equal(0, strcmp(str, str));
Done.
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@198 PS1, Line 198: char str3[] = "1234";
Done.
Done