Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 25:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/fs... PS25, Line 376: Calling THe whole "calling ... called" is kinda weird, how about just drop this first 'Calling'
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/42079/25/src/soc/intel/tigerlake/in... PS25, Line 133: pmc PMC