Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50965 )
Change subject: soc/rockchip/rk3399/sdram: Remove superfluous parameter ......................................................................
soc/rockchip/rk3399/sdram: Remove superfluous parameter
Remove extra parameter in phy_dll_bypass_set, since it does not depend on the channel at hand.
Signed-off-by: Moritz Fischer moritzf@google.com Change-Id: Iae09a6053daf58bf12604e1903c754dc9f1e986f Reviewed-on: https://review.coreboot.org/c/coreboot/+/50965 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: ron minnich rminnich@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/rockchip/rk3399/sdram.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified ron minnich: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c index 07c149d..7a9f0ba 100644 --- a/src/soc/rockchip/rk3399/sdram.c +++ b/src/soc/rockchip/rk3399/sdram.c @@ -114,8 +114,8 @@ udelay(10); }
-static void phy_dll_bypass_set(u32 channel, - struct rk3399_ddr_publ_regs *ddr_publ_regs, u32 freq) +static void phy_dll_bypass_set(struct rk3399_ddr_publ_regs *ddr_publ_regs, + u32 freq) { u32 *denali_phy = ddr_publ_regs->denali_phy;
@@ -1115,7 +1115,7 @@
for (channel = 0; channel < 2; channel++) { phy_pctrl_reset(channel); - phy_dll_bypass_set(channel, rk3399_ddr_publ[channel], ddr_freq); + phy_dll_bypass_set(rk3399_ddr_publ[channel], ddr_freq);
if (channel >= params->num_channels) continue;