Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44790 ) Change subject: gma: Add Bay Trail options ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/libgfxinit/+/44790/5/common/hw-gfx-gma-panel.a... File common/hw-gfx-gma-panel.adb: https://review.coreboot.org/c/libgfxinit/+/44790/5/common/hw-gfx-gma-panel.a... PS5, Line 275: if Config.Gen_Valleyview then
Should have its own flag, e.g. `Has_VLV_PP_Port_Select` and the other could […] I agree. I'll revisit this once I have a baytrail board with a panel
-- To view, visit https://review.coreboot.org/c/libgfxinit/+/44790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ib30ea668da9641ccf1f94f8f25cfb897faa54aaa Gerrit-Change-Number: 44790 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 30 Aug 2020 22:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment