Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43484 )
Change subject: Documentation: Revise "24 hours wait period" rules
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start...
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start...
PS3, Line 58: a change can be merged early with 3 Code-Review+2, ideally not all
Do you mean adding "project or" to the text in this patchset? I'm not sure if I understood your sugg […]
I reworked that part to be stronger and less ambiguous. See next patch set.
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start...
PS3, Line 59: from the same organization, although that's not a hard requirement.
To be able to build stages of a board for different ARCH definetly needs some symmetry of headerfile […]
So better documentation why this is an emergency and, if it can at all be helped (which it usually can), an outside reviewer - I emphasized both a bit more in the next revision.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620e48016a1ceda2ac43f26624ed21af01f6a0a5
Gerrit-Change-Number: 43484
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@scarletltd.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jul 2020 21:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Eric Peers
epeers@google.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment