Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mainboard/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 33:
(8 comments)
hmm
https://review.coreboot.org/c/coreboot/+/34603/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34603/24//COMMIT_MSG@7 PS24, Line 7: h110m-e_m2
very minor nit: this can be the pretty name: […]
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 17: s
You can remove this
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 98: .psi2threshold = 0x10, \ : .psi3threshold = 0x4, \
These can use VR_CFG_AMP too, see table above, column "SA"
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 110: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \
same VR_CFG_AMP thing, row is "IA"
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 123: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \
same, "GT unsliced"
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 136: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \
same, "GT"
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 253: subsystemid 0x1043 0x8694 inherit
move to the previous line, before "device pci 00. […]
Done
https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 275: end
these stale "end" could be moved on the previous line
Done