Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34423 )
Change subject: soc/amd/picasso: Begin adding FSP support
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG@11
PS2, Line 11: e.g. in EDK II,
I do not understand this part. Do you mean it needs EDK II sources?
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG@12
PS2, Line 12: legacy BIOS
But that is unrelated to coreboot? What do you mean by “legacy BIOS”?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb3a3f2599a8ccbc168b1d26a0271f51b71dcf0
Gerrit-Change-Number: 34423
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 13:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment