Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58603 )
Change subject: [RFC]cpu/x86/mp_init.c: Copy BSP chip_info to AP devices
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sorry, tried to review this, but the cpu_info() function starts with a
comment I don't understand / makes no sense to me:
/* We use a #if because we don't want to mess with the &s below. */
The `&s` is aligned up by the stack size, hence we should get the same
result as long is `s` is on the stack, shouldn't we? What do I miss?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9b83b096da07821b7c1f9b36b3e311cd751718
Gerrit-Change-Number: 58603
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 07 Nov 2021 14:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment