Attention is currently required from: Sam McNally, Victor Ding, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52366 )
Change subject: mb/google/zork: Configure IRQs as level triggered for HID over I2C
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52366/comment/31d762a7_865b03cc
PS3, Line 7: HID over I2C
This is not correct.
Patchset:
PS3:
Change looks okay to me. But, before cherry-picking to firmware branch, I think we should ensure that this does not impact any shipped devices. We have seen similar issues with other shipped devices where the touchpad/touchscreen firmware was behaving differently.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52366
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f2182aaf483932304591ab14592f35214ea6efd
Gerrit-Change-Number: 52366
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding
victording@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Victor Ding
victording@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 19:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
