Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: arch/x86: Add symbols for CAR MTRRs in linker script ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30872/1/src/arch/x86/car.ld File src/arch/x86/car.ld:
https://review.coreboot.org/#/c/30872/1/src/arch/x86/car.ld@105 PS1, Line 105: _car_mtrr_size = (_car_mtrr_end - _car_mtrr_start);
I think it would make sense to check for MTRR alignment here. […]
Yeah.. we have checks now on Kconfig variables, could move them here.
AMDs don't now use these symbols. And with AP stacks in CAR too, I am not sure if I want to make this reflect the fixed MTRR cases at all.