Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7292
-gerrit
commit a21c9db1740b98928c80fab4cf3e236db89bcd12 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Fri Oct 31 12:37:49 2014 +1100
drivers/net/ne2k.c: Collect headers and defines to top of file
Change-Id: I2ffb0dd9fe400132f6d430f115f962b5f8578efa Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/drivers/net/ne2k.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index b678d79..ac5230a 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -34,15 +34,25 @@ SMC8416 PIO support added by Andrew Bettison (andrewb@zip.com.au) on 4/3/02 #define ETH_DATA_ALIGN 2 /* Amount needed to align the data after an ethernet header */ #define ETH_MAX_MTU (ETH_FRAME_LEN-ETH_HLEN)
-#include "ns8390.h" -#include <ip_checksum.h> -#include <console/ne2k.h> -#include <arch/io.h> - #define MEM_SIZE MEM_32768 #define TX_START 64 #define RX_START (64 + D8390_TXBUF_SIZE)
+#include <arch/io.h> +#include <console/console.h> +#include <console/ne2k.h> +#include <delay.h> +#include <device/device.h> +#include <device/pci.h> +#include <device/pci_ids.h> +#include <device/pci_ops.h> +#include <stdlib.h> +#include <string.h> +#include <ip_checksum.h> + +#include "ns8390.h" + + static unsigned int get_count(unsigned int eth_nic_base) { unsigned int ret; @@ -415,17 +425,6 @@ int ne2k_init(unsigned int eth_nic_base) {
#else
-#include <delay.h> -#include <stdlib.h> -#include <string.h> -#include <arch/io.h> - -#include <console/console.h> -#include <device/device.h> -#include <device/pci.h> -#include <device/pci_ids.h> -#include <device/pci_ops.h> - static void read_resources(struct device *dev) { struct resource *res; @@ -455,4 +454,4 @@ static const struct pci_driver ne2k_driver __pci_driver = { .device = 0x8029, };
-#endif +#endif /* __PRE_RAM__ */