Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61885 )
Change subject: device: Add device operation to check device driver capabilities
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
This is to provide a way to check further for the enabled devices. […]
These are all good examples when some abstraction is needed in coreboot. However,
what I'm missing is why the existing abstraction mechanisms are not enough and
when we really need something new.
You seem to be concerned about generating clean AML code. Doesn't seem wrong,
but we need to be careful not to buy that with added complexity in coreboot's
code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ed5d27a8e6e441be36b58b54f2a00ec4c1f791f
Gerrit-Change-Number: 61885
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 16 Feb 2022 22:40:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment