Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35376 )
Change subject: coreboot:Add support for boot with tianocore payload ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35376/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35376/5//COMMIT_MSG@7 PS5, Line 7: coreboot:Add Better summary required
https://review.coreboot.org/c/coreboot/+/35376/5//COMMIT_MSG@9 PS5, Line 9: FSP Not true, works without this commit on at least one board.
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35376/5/src/mainboard/google/hatch/... PS5, Line 59: PmTimerDisabled Should be set in SoC/Intel/ No need to make it mainboard specific.
https://review.coreboot.org/c/coreboot/+/35376/5/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/35376/5/src/soc/intel/common/block/... PS5, Line 16: USE_PM_TIMER_DISABLED Inverse: USE_PM_TIMER
https://review.coreboot.org/c/coreboot/+/35376/5/src/soc/intel/common/block/... PS5, Line 20: PM What's a PM timer?