Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 47:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42859/25/src/soc/amd/stoneyridge/Ma... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42859/25/src/soc/amd/stoneyridge/Ma... PS25, Line 273: #cbfs-files-y += apu/amdfw
This is for splitting the patch into smaller ones. […]
Done
https://review.coreboot.org/c/coreboot/+/42859/28/src/soc/amd/stoneyridge/Ma... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42859/28/src/soc/amd/stoneyridge/Ma... PS28, Line 273: #cbfs-files-y += apu/amdfw
i'd prefer to have the stoneyridge and hudson changes squashed into this patch, since those do what […]
Done. Squashed.
https://review.coreboot.org/c/coreboot/+/42859/25/src/southbridge/amd/pi/hud... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42859/25/src/southbridge/amd/pi/hud... PS25, Line 208: #cbfs-files-y += apu/amdfw
same here
Done
https://review.coreboot.org/c/coreboot/+/42859/28/src/southbridge/amd/pi/hud... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42859/28/src/southbridge/amd/pi/hud... PS28, Line 208: #cbfs-files-y += apu/amdfw
same as my comment on the corresponding change in the stoneyridge makefile
Done Squashed.